[Bug 722311] matroskaparse: should try to identify data on stream header before going with a blind

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jan 20 00:55:28 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=722311
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266497|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-20 08:55:23 UTC ---
Review of attachment 266497:
 --> (https://bugzilla.gnome.org/review?bug=722311&attachment=266497)

Looks good in general

::: gst/matroska/matroska-parse.c
@@ +311,3 @@
+  /* reset stream type */
+  parse->common.is_webm = FALSE;
+  parse->common.has_video = FALSE;

These also need to be reset in matroskademux for consistency

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list