[Bug 722345] directfb: video sink crashes when used with ext_surface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722345
  GStreamer | gst-plugins-bad | 1.2.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266558|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-20 09:25:21 UTC ---
Review of attachment 266558:
 --> (https://bugzilla.gnome.org/review?bug=722345&attachment=266558)

::: ext/directfb/dfbvideosink.c
@@ +440,3 @@
+    meta->dfbvideosink->ext_surface->Lock(meta->dfbvideosink->ext_surface,
DSLF_READ, &data, &pitch);
+    alloc_size = meta->height * pitch;
+    meta->dfbvideosink->ext_surface->Unlock(meta->dfbvideosink->ext_surface);

This is likely to be completely wrong for multi-planar formats like I420. See
the code a few lines above that handles those and does basically the same.

Also all this all (including existing code) can only work properly if we can
allocate with videometa... which upstream explicitly has to set on the buffer
pool.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.