[Bug 722370] rtprtxsend: push rtx buffers from a different thread to avoid long retransmission delays

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722370
  GStreamer | gst-plugins-good | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com

--- Comment #1 from Wim Taymans <wim.taymans at gmail.com> 2014-01-20 13:13:32 UTC ---
(In reply to comment #0)
> Please note that there are still two unit tests failing at random:
> rtprtx::test_drop_multiple_sender and rtprtx::test_drop_one_sender. These unit
> tests are quite complex and weird, but despite having analyzed them fully, I am
> unable to find a reason for their failure. It looks like some rtx buffers are
> lost between rtprtxsend and rtprtxreceive in their pipelines, sometimes. At
> this point, I'm all for removing them, since they do not offer much in my
> opinion. The functionality is more or less also tested in the rest of the
> tests, which work fine.

Please don't remove the tests, the reason why they fail in this case is because
they reveal a bug in the elements. The EOS event jumps over the RTX packets and
causes the pipeline to stop early and racily. The rtx sender should probably
place the EOS event in the queue and only push it forward when the queue is
drained.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.