[Bug 722670] add GRAY8/GRAY16_LE/GRAY16_BE support to glupload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722670
  GStreamer | gst-plugins-gl | 1.2.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266835|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-21 08:57:05 UTC ---
Review of attachment 266835:
 --> (https://bugzilla.gnome.org/review?bug=722670&attachment=266835)

Generally looks good but why not also add support to gldownload? :)

::: gst-libs/gst/gl/gstglupload.c
@@ +145,3 @@

+#define COMPOSE_WEIGHT \
+    "const vec2 compose_weight = vec2(0.996109, 0.003891);\n"

Please write a comment where these magic numbers come from, it might not be
obvious for everybody :)

@@ +1063,3 @@
+      break;
+    case GST_VIDEO_FORMAT_GRAY16_LE:
+      frag_prog = g_strdup_printf (upload->priv->COMPOSE, 'a', 'r');

I'm not 100% sure if this is correct for big endian systems too. Maybe you need
to do the inverse there, as GL formats are usually native-endianness.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.