[Bug 722311] matroskaparse: should try to identify data on stream header before going with a blind

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722311
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266829|none                        |accepted-commit_now
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-21 09:13:25 UTC ---
Review of attachment 266829:
 --> (https://bugzilla.gnome.org/review?bug=722311&attachment=266829)

Good to go IMHO, unless you want to implement the 3D support. Why does that
have different caps anyway?

::: gst/matroska/matroska-parse.c
@@ +3049,3 @@
+ * type and whether it has video or not.
+ *
+ * FIXME: Do something with video/x-matroska-3d if possible

Yes, see gst-plugins-base/gst/typefind/gsttypefindfunctions.c

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.