[Bug 722656] Scoring system within videoconvert ranks colour loss very low

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722656
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266808|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-21 09:17:37 UTC ---
Review of attachment 266808:
 --> (https://bugzilla.gnome.org/review?bug=722656&attachment=266808)

::: gst/videoconvert/gstvideoconvert.c
@@ +149,3 @@
 #define SCORE_CHROMA_H_LOSS      16
 #define SCORE_DEPTH_LOSS         32
+#define SCORE_COLOR_LOSS         64

COLOR_LOSS is used if we convert from RGB, YUV, GRAY to one of the others. I
think RGB<->YUV and GRAY->(RGB|YUV) should get a low score here (like the
previous 2). The other conversions should get a very high score like 64 indeed.

Special case is the Y800 and Y16 color format, which basically is like GRAY
(and should be treated like GRAY for this case) but within YUV limits.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.