[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263277|none                        |reviewed
             status|                            |

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-21 09:26:59 UTC ---
Review of attachment 263277:
 --> (https://bugzilla.gnome.org/review?bug=706054&attachment=263277)

I did not have time to review it completely yet.

::: gst-libs/gst/egl/egl.h
@@ +106,3 @@
+    gpointer blocking_allocate_data, GDestroyNotify destroy_func);
+void gst_egl_image_buffer_pool_replace_last_buffer (GstEGLImageBufferPool *
pool, GstBuffer * buffer);
+void gst_egl_image_buffer_pool_get_video_infos (GstEGLImageBufferPool * pool,
GstVideoFormat * format, gint * width, gint * height);

Why not return a GstVideoInfo here?

@@ +109,3 @@
+
+/* TODO: will be removed after moving gst_egl_image_allocator_alloc_eglimage
*/
+GstAllocator *gst_egl_image_buffer_pool_get_allocator (GstEGLImageBufferPool *
pool);

Do we want to move it, and where and how? It's involving lots of GL calls and
with that we get lots of problems :)

Maybe for all this we should just get gst-plugins-gl into shape.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.