[Bug 721953] pango: basetextoverlay: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721953
  GStreamer | gst-plugins-base | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267140|none                        |reviewed
             status|                            |

--- Comment #12 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-01-24 16:44:18 UTC ---
Review of attachment 267140:
 --> (https://bugzilla.gnome.org/review?bug=721953&attachment=267140)

::: ext/pango/gstbasetextoverlay.c
@@ +153,3 @@
+
+#define BASE_TEXT_OVERLAY_ALL_CAPS BASE_TEXT_OVERLAY_CAPS ";" \
+    GST_VIDEO_CAPS_MAKE_WITH_FEATURES ("ANY", GST_VIDEO_FORMATS_ALL)

I think this is right for SINK caps, but for SRC caps you already know that for
this case you'll add (and require) the composition meta support. So I'm
wondering why you don't do that ?

@@ +1109,1 @@
+  peer_caps = gst_pad_peer_query_caps (otherpad, overlay_filter);

With the proposed template modification, I don't see why you would need a
special implementation of the caps query.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.