[Bug 723134] [hlsdemux] Playback may not always start when using a file:// url

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723134
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267357|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-29 19:44:39 UTC ---
Review of attachment 267357:
 --> (https://bugzilla.gnome.org/review?bug=723134&attachment=267357)

::: gst-libs/gst/uridownloader/gsturidownloader.c
@@ +413,3 @@
   GST_DEBUG_OBJECT (downloader, "Waiting to fetch the URI %s", uri);
+  while (!downloader->priv->cancelled &&
!downloader->priv->download->completed)
+    g_cond_wait (&downloader->priv->cond, GST_OBJECT_GET_LOCK (downloader));

This will break with the g_cond_signal() in gst_uri_downloader_bus_handler
which does not set any of the two variables. I think it should set cancelled :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.