[Bug 723075] matroskademux: invalid handling of flushing seek without start position

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 29 12:22:53 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=723075
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267276|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-29 20:22:47 UTC ---
Review of attachment 267276:
 --> (https://bugzilla.gnome.org/review?bug=723075&attachment=267276)

::: gst/matroska/matroska-demux.c
@@ +2188,2 @@
 finish:
+  if (keyunit && (cur_type != GST_SEEK_TYPE_NONE)) {

I think this part is not correct, if the keyunit flag is set we should move to
a keyunit.

@@ +2227,2 @@
   /* update some (segment) state */
+  if (cur_type != GST_SEEK_TYPE_NONE)

Also here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list