[Bug 723271] videotestsrc: fix a warning if downstream does not propose a buffer pool

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723271
  GStreamer | gst-plugins-base | 1.x

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267620|none                        |reviewed
             status|                            |

--- Comment #1 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-30 16:04:01 UTC ---
Review of attachment 267620:
 --> (https://bugzilla.gnome.org/review?bug=723271&attachment=267620)

::: gst/videotestsrc/gstvideotestsrc.c
@@ -651,1 +652,5 @@
   config = gst_buffer_pool_get_config (pool);
+
+  gst_query_parse_allocation (query, &caps, NULL);
+  if (caps)
+    gst_buffer_pool_config_set_params (config, caps, size, min, max);

How about moving this inside the if(pool == NULL) condition?

AFAIU if the pool was created downstream it should already contain some
configuration parameters, including the caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.