[Bug 721953] pango: basetextoverlay: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721953
  GStreamer | gst-plugins-base | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267658|none                        |needs-work
             status|                            |

--- Comment #22 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-01-30 18:03:09 UTC ---
Review of attachment 267658:
 --> (https://bugzilla.gnome.org/review?bug=721953&attachment=267658)

Very close  now.

::: ext/pango/gstbasetextoverlay.c
@@ +555,3 @@
+    gst_caps_unref (overlay->sw_template_caps);
+    overlay->sw_template_caps = NULL;
+  }

Not that important, but gst_caps_replace() is could be used.

::: ext/pango/gstbasetextoverlay.h
@@ +159,3 @@
     GstVideoOverlayComposition *composition;
+
+    GstCaps *sw_template_caps;

I would suggest moving that into the class instance, a bit more difficult to
read, but I think this is where it belongs.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.