[Bug 723271] videotestsrc: fix a warning if downstream does not propose a buffer pool

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723271
  GStreamer | gst-plugins-base | 1.x

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> 2014-01-31 09:57:57 UTC ---
(In reply to comment #1)
> Review of attachment 267620 [details]:
> 
> ::: gst/videotestsrc/gstvideotestsrc.c
> @@ -651,1 +652,5 @@
>    config = gst_buffer_pool_get_config (pool);
> +
> +  gst_query_parse_allocation (query, &caps, NULL);
> +  if (caps)
> +    gst_buffer_pool_config_set_params (config, caps, size, min, max);
> 
> How about moving this inside the if(pool == NULL) condition?
> 
> AFAIU if the pool was created downstream it should already contain some
> configuration parameters, including the caps.

Hi Thiago, thx for your point of view. Actually I thought about it but I think
the downstream can also forget to do it.

Hi Sebastian, you have accepted the commit but maybe you missed #1 comment ?

Let me know and then I can push it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.