[Bug 723289] cairooverlay: add RGB16 support

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 31 05:31:15 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=723289
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267719|none                        |accepted-commit_now
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-31 13:31:09 UTC ---
Review of attachment 267719:
 --> (https://bugzilla.gnome.org/review?bug=723289&attachment=267719)

::: ext/cairo/gstcairooverlay.c
@@ +166,3 @@
+      GST_WARNING ("No matching cairo format for %s",
+          gst_video_format_to_string (GST_VIDEO_FRAME_FORMAT (frame)));
+      return GST_FLOW_ERROR;

So I think this is ok, but could as well be an assertion. It just must not
happen unless something is really really wrong elsewhere already :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list