[Bug 703344] Add support for GstVideoMeta and GstVideoCropMeta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703344
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267714|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-31 13:33:10 UTC ---
Review of attachment 267714:
 --> (https://bugzilla.gnome.org/review?bug=703344&attachment=267714)

In general this looks good... but you don't use GstVideoMeta or GstVideoFrame
anywhere, only GstVideoInfo. So for each buffer you'll have to look at the
videometa to get the current buffer's strides and offsets, and then use them in
the shaders.

And to get the videometa you will need to add it in the GL buffer pool and
other elements into the reply of the allocation query.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.