[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267723|none                        |reviewed
             status|                            |

--- Comment #51 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-31 13:40:54 UTC ---
Review of attachment 267723:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=267723)

Just skipped over the patch, some first comments below :)

::: docs/libs/Makefile.am
@@ +60,3 @@
    
$(top_builddir)/gst-libs/gst/allocators/libgstallocators- at GST_API_VERSION@.la \
     $(top_builddir)/gst-libs/gst/audio/libgstaudio- at GST_API_VERSION@.la \
+    $(top_builddir)/gst-libs/gst/cenc/libgstcenc- at GST_API_VERSION@.la \

I think to get started it would make sense to get this into gst-plugins-bad
first until we're really sure about the API. And then have elements use that
for some time.


Also maybe we can have a "drm" library, that contains both the cenc and the
dtcp-ip stuff... and whatever else comes in the future?

::: gst-libs/gst/cenc/gstcencevent.h
@@ +33,3 @@
+#define GST_EVENT_CENC_PSSH_INIT GST_EVENT_MAKE_TYPE(330, \
+    GST_EVENT_TYPE_DOWNSTREAM | GST_EVENT_TYPE_SERIALIZED | \
+    GST_EVENT_TYPE_STICKY | GST_EVENT_TYPE_STICKY_MULTI)

Wouldn't it be better to have these events as metas on the buffers to which
they apply? Also you can't make custom events like this, you have to use the
generic "custom downstream" event type and then your custom element would only
have a different name in the structure. See how the force-keyunit element for
example is implemented

Also wouldn't the PSSH_INIT be possible to just put into the caps (because
there is only one, right?), and the PSSH one as a meta (because there can be
many, one per buffer in the worst case)?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.