[Bug 703344] Add support for GstVideoMeta and GstVideoCropMeta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703344
  GStreamer | gst-plugins-gl | git

--- Comment #4 from Matthew Waters <ystreet00 at gmail.com> 2014-01-31 15:21:11 UTC ---
(In reply to comment #2)
> Review of attachment 267714 [details]:
> 
> In general this looks good... but you don't use GstVideoMeta or GstVideoFrame
> anywhere, only GstVideoInfo. So for each buffer you'll have to look at the
> videometa to get the current buffer's strides and offsets, and then use them in
> the shaders.

There are three upload paths in GstGLUpload
1. GstGLMemory - needs to be updated for strides.
2. GstVideoGLTextureUploadMeta - not relevant
3. System Memory - depending on which function you call depends on if you get
proper stride support.  Two paths are available for this:
3a. gst_gl_upload_perform_with_buffer() - wraps (3b.) with GstVideoFrame
map/unmap which will update upload->in_info with stride and offsets.
3b. gst_gl_upload_perform_with_data() - At the moment, does not touch
upload->in_info so you get whatever is set.

All the elements use gst_gl_upload_perform_with_buffer() anyway.

> And to get the videometa you will need to add it in the GL buffer pool and
> other elements into the reply of the allocation query.

Already there.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.