[Bug 731974] videodecoder: parse source data until a frame is obtained

Tue Jul 1 01:17:07 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=731974
  GStreamer | gst-plugins-base | 1.2.4

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278848|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-01 08:17:02 UTC ---
Review of attachment 278848:
 --> (https://bugzilla.gnome.org/review?bug=731974&attachment=278848)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +926,3 @@
     ret = decoder_class->parse (dec, priv->current_frame,
         priv->input_adapter, at_eos);
+    available = gst_adapter_available_fast (priv->input_adapter);

Makes sense but please add a counter here to check if we iterate more than
twice without consuming data, and in that case error out completely (it would
be a bug in the subclass!)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.