[Bug 732167] h264parse: default to byte-stream/nalu format (Annex B)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732167
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279174|none                        |accepted-commit_after_freez
             status|                            |e

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-01 08:20:31 UTC ---
Review of attachment 279174:
 --> (https://bugzilla.gnome.org/review?bug=732167&attachment=279174)

Can be pushed after 1.4.0 release, mostly because it could break some code that
assumes the current behaviour and because ↓

Also we should decide on how to handle alignment=nal in general, and make sure
h264parse is doing the right thing here.

::: gst/videoparsers/gsth264parse.c
@@ +369,3 @@
   if (!align)
+    align = format == GST_H264_PARSE_FORMAT_BYTE ? GST_H264_PARSE_ALIGN_NAL :
+        GST_H264_PARSE_ALIGN_AU;

Add some brackets here, even if not requirede :)

(format == BYTE) ? NAL : AU

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.