[Bug 732203] h264parse: improve handling of byte-stream/au format

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732203
  GStreamer | gst-plugins-bad | git

--- Comment #16 from Gwenole Beauchesne <gb.devel at gmail.com> 2014-07-01 08:32:19 UTC ---
(In reply to comment #15)
> Review of attachment 279297 [details]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1057,3 @@
> +      !(h264parse->state & GST_H264_PARSE_STATE_VALID_PICTURE_HEADERS) ||
> +      (h264parse->state & GST_H264_PARSE_STATE_GOT_SLICE))
> +    gst_h264_parse_reset_frame (h264parse);
> 
> Wouldn't this throw away the complete AU if there is a broken SEI between SPS
> and PPS?

Yes, you are right. On the other hand, I can't check the NAL unit type here
(for SEI) because that could be used in cases where the NAL unit could not be
parsed at all.

Maybe add a check for SEI and alignment=au if gst_h264_parse_process_nal()
failed and goto out in this case?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.