[Bug 732750] New: videoaggregator: broken locking in setcaps function

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732750
  GStreamer | gst-plugins-bad | git

           Summary: videoaggregator: broken locking in setcaps function
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I don't really understand how the locking is supposed to work there - at least
four different locks at the same time! Respect! (PAD_STREAM_LOCK,
AGGREGATOR_SETCAPS_LOCK, AGGREGATOR_LOCK, OBJECT_LOCK)

All I can say is that it's buggy:

Line 558 does GST_OBJECT_UNLOCK (vagg); and then line 613 and 633 call
GST_OBJECT_UNLOCK again.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.