[Bug 703486] Implement GstNavigation interface in glimagesink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703486
  GStreamer | gst-plugins-gl | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279919|none                        |needs-work
             status|                            |

--- Comment #15 from Matthew Waters <ystreet00 at gmail.com> 2014-07-05 23:52:19 UTC ---
Review of attachment 279919:
 --> (https://bugzilla.gnome.org/review?bug=703486&attachment=279919)

Some minor nitpicks

::: gst-libs/gst/gl/x11/gstglwindow_x11.c
@@ +176,3 @@
   g_source_attach (window_x11->x11_source, window_x11->main_context);

+

spurious new line

@@ +254,3 @@
       &text_property, &text_property, 0, 0, NULL, &wm_hints, NULL);

+

spurious new line

@@ +593,3 @@
+        g_signal_emit_by_name (window, "mouse-event",
+            event.type ==
+            KeyPress ? "mouse-button-press" : "mouse-button-release",

s/KeyPress/ButtonPress/

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.