[Bug 703486] Implement GstNavigation interface in glimagesink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jul 6 08:24:40 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=703486
  GStreamer | gst-plugins-gl | git

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-06 15:24:35 UTC ---
Review of attachment 279918:
 --> (https://bugzilla.gnome.org/review?bug=703486&attachment=279918)

::: ext/gl/gstglimagesink.c
@@ +197,3 @@
+
+  if (GST_IS_PAD (pad) && GST_IS_EVENT (event))
+    gst_pad_send_event (pad, event);

gst_pad_push_event (GST_VIDEO_SINK_PAD (sink), event);

@@ +481,3 @@
+        (gst_glimage_sink_key_event_cb), gl_sink);
+    g_signal_connect (window, "mouse-event", G_CALLBACK
+        (gst_glimage_sink_mouse_event_cb), gl_sink);

You probably want to disconnect the signal handlers again when the sink
instance is disposed

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list