[Bug 732939] wavenc doesn't create a proper header for data from omxaacdec
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jul 9 08:11:27 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=732939
GStreamer | gst-omx | 1.2.4
--- Comment #12 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-09 15:11:24 UTC ---
(In reply to comment #11)
> Created an attachment (id=280272)
--> (https://bugzilla.gnome.org/attachment.cgi?id=280272)
> filesrc ! aacparse ! omxaacdec ! audioconvert ! wavenc ! filesink
>
> this gstomxaacdec.c is what I made based on gstomxmp3dec.c and possibly wrong.
>
>
> static void
> gst_omx_aac_dec_class_init (GstOMXAACDecClass * klass)
> {
> GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
> GstOMXAudioDecClass *audiodec_class = GST_OMX_AUDIO_DEC_CLASS (klass);
>
> audiodec_class->set_format = GST_DEBUG_FUNCPTR (gst_omx_aac_dec_set_format);
> audiodec_class->is_format_change =
> GST_DEBUG_FUNCPTR (gst_omx_aac_dec_is_format_change);
> audiodec_class->get_samples_per_frame =
> GST_DEBUG_FUNCPTR (gst_omx_aac_dec_get_samples_per_frame);
>
> audiodec_class->cdata.default_sink_template_caps = "audio/mpeg, "
> "mpegversion=(int)[2,4],"
> "rate=(int)[8000,48000], "
> "channels=(int)[1,2], " "parsed=(boolean) true";
I don't think a decoder should set parsed=true. Also, in your test file, you
have 6 channels, while your class only supports up to 2. Negotiation should
simply fail.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list