[Bug 730441] dmabuf: shared the mapping with shared copies of the memory

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730441
  GStreamer | gst-plugins-base | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-10 21:02:17 UTC ---
This patch is actually causing regressions. On a shared dmabuf memory, calling
gst_dmabuf_memory_get_fd() will return -1.

Other problems, the parent memory is no longer always a dmabuf memory, hence
calling gst_dmabuf_map (parent, ...) will lead to crash.

A solution would be:

- Implement dmabuf mapping in V4l2Memory
- Change call to gst_dmabuf_map() into gst_memory_map()
- Set the FD correctly on _share, close only if no parent

This way we would not have to dup the FD in v4l2, though small some code
duplication will exist between the allocator and v4l2.

This is a lot so close to a release, reverting would also fix the regression,
with the added cost of doing a lot of dup().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.