[Bug 732851] funnel: storing sticky events after event callback

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732851
  GStreamer | gstreamer (core) | 1.3.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280690|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-16 15:01:49 UTC ---
Review of attachment 280690:
 --> (https://bugzilla.gnome.org/review?bug=732851&attachment=280690)

::: plugins/elements/gstfunnel.c
@@ +302,2 @@
     if (GST_EVENT_TYPE (event) == GST_EVENT_EOS) {
+      GST_OBJECT_UNLOCK (funnel);

This should probably be GST_OBJECT_LOCK

@@ +315,3 @@
+    unlock = TRUE;
+    GST_PAD_STREAM_LOCK (funnel->srcpad);
+    GST_OBJECT_UNLOCK (funnel);

And this too... and why do you take the stream lock here? That seems wrong, you
already have it here (and never release it anyway)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.