[Bug 726329] vp8enc: Add support for caps renegotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726329
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272656|accepted-commit_after_freez |needs-work
             status|e                           |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-18 12:20:03 UTC ---
Review of attachment 272656:
 --> (https://bugzilla.gnome.org/review?bug=726329&attachment=272656)

::: ext/vpx/gstvp8enc.c
@@ +1511,3 @@
   GST_DEBUG_OBJECT (video_encoder, "set_format");

+  g_mutex_lock (&encoder->encoder_lock);

Why is the encoder lock needed here for all the duration of the drain() call?
Doesn't seem necessary... and

@@ +1901,2 @@
   gst_vp8_enc_process (encoder);
+  g_mutex_lock (&encoder->encoder_lock);

... this wouldn't be neecessary then.

Try to keep the lock outside the finish/drain functions and only hold it when
necessary. Note that finish() and set_format() are both called with the stream
lock held.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.