[Bug 733616] v4l2object: get current bufferpool min and max in propose_allocation()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733616
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281494|none                        |rejected
             status|                            |

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-23 18:25:42 UTC ---
Review of attachment 281494:
 --> (https://bugzilla.gnome.org/review?bug=733616&attachment=281494)

No, that isn't right. Propose allocation shall return it's minimum, regardless
if a pool was configured or not. It's upstream element role to deactivate the
pool if he want to renegotiate it. The only thing missing here is code that
read the CID MIN_BUFFERS_FOR_INPUT, and upgrade the minimum from that
(basically min = MAX(MIN_BUFFERS_FOR_INPUT, GST_V4L2_MIN_BUFFERS). See BaseSrc
code of an example of how to re-negotiate a buffer pool (though even there, I
think it should be improved a bit).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.