[Bug 733757] [PATCH] GstURIHandlers which return NULL GErrors cause GStreamer to crash

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733757
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281720|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-07-28 07:09:42 UTC ---
Review of attachment 281720:
 --> (https://bugzilla.gnome.org/review?bug=733757&attachment=281720)

::: gst/gsturi.c
@@ +608,2 @@
       GST_WARNING ("%s didn't accept URI '%s': %s", GST_OBJECT_NAME (ret),
uri,
+          (uri_err != NULL) ? uri_err->message : "<GError variable NULL>");

If err is NULL this is a programming error in the element. Can you make that a
g_warning() or g_critical()?

Also we should fix the elements :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.