[Bug 643252] Improve opencv facedetect performance

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=643252
  GStreamer | gst-plugins-bad | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281892|none                        |reviewed
             status|                            |

--- Comment #31 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-28 22:55:10 UTC ---
Review of attachment 281892:
 --> (https://bugzilla.gnome.org/review?bug=643252&attachment=281892)

Looks good to me. I would suggest to split this though 1) Port gst 0.10 doc 2)
send warning if cascade isn't found and 3) Well this one, but with a more
descriptive comment.

::: ext/opencv/gstfaceblur.c
@@ +354,3 @@
+          ("missing faceblur profile file %s", filter->profile));
+      filter->sent_profile_load_failed_msg = TRUE;
+    }

This is slightly unrelated, could have been a seperate patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.