[Bug 733614] Zero copy path between omxvideodec and v4l2sink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jul 29 09:49:03 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=733614
  GStreamer | gst-omx | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281962|none                        |needs-work
             status|                            |

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-29 16:49:00 UTC ---
Review of attachment 281962:
 --> (https://bugzilla.gnome.org/review?bug=733614&attachment=281962)

::: omx/gstomxvideodec.c
@@ +2607,3 @@
         GST_BUFFER_POOL_OPTION_VIDEO_META);
   }
   gst_buffer_pool_set_config (pool, config);

This is still not right, You need to check the return value, otherwise the pool
is not yet configured, and the saved config might have been changed in a way
that it does not work for our use case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list