[Bug 733974] gstbufferpool::default_alloc_buffer does not fail if buffer allocation fails

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733974
  GStreamer | gstreamer (core) | 1.4.0

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-30 13:04:32 UTC ---
commit 59749833bb702d59d7a6c0c6935f388dd602b2f2
Author: Mohammed Sameer <msameer at foolab.org>
Date:   Wed Jul 30 15:46:22 2014 +0300

    bufferpool: Add missing error checking to default_alloc_buffer()

    default_alloc_buffer() calls gst_buffer_new_allocate() but does not check
for
    failed allocation.

    This patch makes default_alloc_buffer() return an error (GST_FLOW_ERROR) if
    buffer allocation fails.

    https://bugzilla.gnome.org/show_bug.cgi?id=733974

Shall we backport this one ? Was there a failing use case for you ? For the
context, this never happens with system allocator, as it will abort the
application and other uses their own buffer pool, with the own allocate method.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.