[Bug 731890] New imagesequencesrc element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731890
  GStreamer | gst-plugins-bad | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282033|none                        |needs-work
             status|                            |

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-30 13:14:48 UTC ---
Review of attachment 282033:
 --> (https://bugzilla.gnome.org/review?bug=731890&attachment=282033)

Please use git format-patch. I'll stop there, maybe I'm confused. So what do
you want to propose, a playlist base image sequence or a mix of
playlist/pattern element ?

::: gst/sequences/gstimagesequence.c
@@ +39,3 @@
+    GST_VERSION_MINOR,
+    imagesequencesrc,
+    "Reads/Writes buffers from sequentially named image files",

>From playlist ?

::: gst/sequences/gstimagesequencesrc.c
@@ +20,3 @@
+ * SECTION:element-gstimagesequencesrc
+ *
+ * Reads buffers from sequentially named files. 

Playlist ?

@@ +25,3 @@
+ * <title>Example launch line</title>
+ * |[
+ * gst-launch-1.0 -v imagesequencesrc location="0d%.png" framerate="24/1" !
decodebin ! videoconvert ! xvimagesink

Didn't you say it's a playlist ?

@@ +37,3 @@
+ * image,location=/path/to/c.png
+ * ]|
+ * </refsect2>

Please update the doc, it's confused. This could have been implemented with
GKeyFile API, or standard m3u rather then your own format/parser no ?

@@ +88,3 @@
+  PROP_START_INDEX,
+  PROP_STOP_INDEX,
+  PROP_FRAMERATE,

Do you still need this one as you seem to say you set the framerate in the
playlist ?

@@ +90,3 @@
+  PROP_FRAMERATE,
+  PROP_LOOP,
+  PROP_FILENAMES,

Playlist ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.