[Bug 727746] Factor buffer flags-to-string code

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 2 15:52:27 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=727746
  GStreamer | gstreamer (core) | git

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-02 22:52:22 UTC ---
(In reply to comment #9)
> Hmm, I'm not sure what's the consensus here. Tim, you agreed with the third
> patch, but the first two were marked as commit-now (not sure by whom). If I was
> to push the third patch, the only comment about it is to move it to a private
> header ?

The two first patches are independent afaict and should be pushed.

The code duplication makes sense to de-duplicate. Question was how to best do
that. The two options afaict are the third patch or a variant thereof as
suggested in comment #6. I would prefer to de-duplicate the code but not make
it public API for the time being, and if I interpret Sebastian's comment #4
correctly he also prefers that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list