[Bug 731036] Plenty of temporary files/directories are not removed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731036
  GStreamer | packages | git

Andoni Morales <ylatuya> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277614|none                        |needs-work
             status|                            |

--- Comment #2 from Andoni Morales <ylatuya at gmail.com> 2014-06-03 13:50:43 UTC ---
Review of attachment 277614:
 --> (https://bugzilla.gnome.org/review?bug=731036&attachment=277614)

::: cerbero/ide/xcode/fwlib.py
@@ +194,3 @@
                         shell.call('ar -cqS %s %s-%s' % (libname, libprefix,
obj_f), tmpdir_thinarch)
                         object_files_md5.append(md5)
+                shutil.rmtree(lib_tmpdir)

In this same function tmpdir should also be deleted. It's created in:

162         tmpdir = tempfile.mkdtemp()

::: cerbero/packages/osx/packager.py
@@ +306,3 @@
         pb = ProductBuild()
         pb.create_package(distro_path, output_file,
[self.package.relative_path('.')])
+        shutil.rmtree(distro_path)

distro_path should be os.path.join(self.tmp, "Distrobition.xml") so that's it's
deleted with the temporary directory if keep_temp = False

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.