[Bug 728490] v4l2src: Missing unref in decide_allocation

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jun 3 11:57:30 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728490
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275984|none                        |committed
             status|                            |

--- Comment #19 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-06-03 18:57:26 UTC ---
(From update of attachment 275984)
commit 2dbd9d948dc35dfd6b63f3fc7b79a8b0d6c66c07
Author: Aurélien Zanelli <aurelien.zanelli at parrot.com>
Date:   Tue May 6 16:14:07 2014 +0200

    v4l2src: fix bufferpool leak in decide_allocation()

    gst_query_parse_nth_allocation_pool() ref the pool it returns and
    gst_query_set_nth_allocation_pool()/gst_query_add_allocation_pool are
    transfert none.
    So when we replace it by our own pool in DMA/MMAP/USERPTR cases, we
    must unref the one given by gst_query_parse_nth_allocation_pool().
    In all cases, pool should be unref at the end so to make it clear, we
    also ref our own pool when using it.

    https://bugzilla.gnome.org/show_bug.cgi?id=728490

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list