[Bug 727746] Factor buffer flags-to-string code

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727746
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277806|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-04 09:30:15 UTC ---
Review of attachment 277806:
 --> (https://bugzilla.gnome.org/review?bug=727746&attachment=277806)

::: plugins/elements/gstelements_private.c
@@ +24,3 @@
+#  include "config.h"
+# endif
+#endif

And why here this #ifndef GST_LICENSE foo? Seems like something wrong with the
includes somewhere

@@ +67,3 @@
+      end++;
+    }
+  }

I would prefer if this just used GString but otherwise ok :)

::: plugins/elements/gstelements_private.h
@@ +28,3 @@
+#  include "config.h"
+# endif
+#endif

Why this? Just include config.h in the source file

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.