[Bug 730830] hlsdemux: Remove \" sign from decryption KEY url does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730830
  GStreamer | gst-plugins-bad | 1.3.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277824|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-04 10:17:03 UTC ---
Review of attachment 277824:
 --> (https://bugzilla.gnome.org/review?bug=730830&attachment=277824)

Please put your real name into your GIT settings, so it shows up in the From
line

::: ext/hls/m3u8.c
@@ +243,3 @@

+static gboolean
+remove_quotation_marks_around_uri (gchar * uri)

unquote_string() maybe? Not really URI related. It converts any "blablabla"
string to the equivalent without quotes... inplace

@@ +247,3 @@
+  gchar *key_ret;
+
+  /* handle the \"key\" case *

not really key specific anymore

@@ +261,3 @@
+    } else {
+      GST_WARNING
+          ("Decryption key URL parsing - cannot find finalizing quotation
mark");

Not always correct if used for the I-Frame lists

@@ +265,3 @@
+    }
+  }
+  return TRUE;

You have to return uri here. You might change the pointer to skip over the
initial stuff until the initial "

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.