[Bug 701110] videomixer: sinkpads GSList is not protected for multi-threading

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701110
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271268|none                        |reviewed
             status|                            |

--- Comment #17 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-06-04 14:33:06 UTC ---
Review of attachment 271268:
 --> (https://bugzilla.gnome.org/review?bug=701110&attachment=271268)

::: gst/videomixer/videomixer2.c
@@ +2160,2 @@
   GST_COLLECT_PADS_STREAM_LOCK (mix->collect);
+  GST_VIDEO_MIXER2_LOCK (mix);

Normally, because we have unlocked, we should be validating the state before
continuing. Is there any other calls that should induce a different behaviour
here ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.