[Bug 731164] hlsdemux: Attempt to reload variant playlist if refreshing playlist or downloading fragments failed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731164
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277810|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-04 14:50:46 UTC ---
Review of attachment 277810:
 --> (https://bugzilla.gnome.org/review?bug=731164&attachment=277810)

Thanks for the patch! Looks good except for some minor issues

::: ext/hls/m3u8.c
@@ +138,3 @@
+  dup->targetduration = self->targetduration;
+  dup->allowcache = self->allowcache;
+  dup->key = g_strdup (self->key);

You should probably copy the IV too (also check if you have all the members of
the struct then)

@@ +843,3 @@
+      GST_ERROR
+          ("Cannot update variant playlist, unable to match all playlists");
+      goto out;

Why is that an error always? Maybe we played the low-bitrate variant and the
high-bitrate variant was dropped?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.