[Bug 731169] wavparse: Puts codec_data on raw audio caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731169
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277863|none                        |accepted-commit_now
             status|                            |

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-04 18:40:56 UTC ---
(From update of attachment 277863)
Looks fine, minor nit:

>+    /* If we got raw audio from upstream, we remove the codec_data field,
>+       which may have been added if the wav header included an extended
>+       chunk. We want to keep it for non raw audio. */

Note how our code usually uses a '*' at the beginning of each comment line for
multi-line comments:

>     /* do more sanity checks of header fields
>      * (these can be sanitized by gst_riff_create_audio_caps()
>      */

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.