[Bug 731286] New: avauddec: Not negotiating allocation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731286
  GStreamer | gst-libav | git

           Summary: avauddec: Not negotiating allocation
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-libav
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: nicolas.dufresne at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


The audio decoder is not using the base class to do allocation. This results in
not operating an allocation query, which isn't ideal.

What need to be done, from my point of view, is move the code from
gst_ffmpegauddec_negotiate() to be an override of GstAudioDecoder::negotiate,
and then call gst_audio_decoder_negotiate() instead.

Doing this will ensure pending events are sent (avoid miss-ordering), will
handle if caps didn't change, will run device_allocation() hence use the
downstream allocator if any. It will also allow implement decided_allocation in
a way that we can update the allocation params witch required alignement (15).

(If audio sink do have buffer pool, note that the base class does not use that
at the moment.)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.