[Bug 728443] Duplicated symbols in several plugins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728443
  GStreamer | packages | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278002|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-06 11:35:29 UTC ---
Review of attachment 278002:
 --> (https://bugzilla.gnome.org/review?bug=728443&attachment=278002)

::: gst-libs/gst/video/Makefile.am
@@ +71,3 @@
+    video-overlay-composition.h \
+    colorspaceconvert.h    \
+    gstcms.h

They should all be included by video.h

::: gst-libs/gst/video/colorspaceconvert.h
@@ +26,3 @@
+G_BEGIN_DECLS
+
+typedef struct _GstColorSpaceConvert GstColorSpaceConvert;

Maybe all this should be called GstVideoConvert or GstVideoConverter or
something like that? It's not (only) about colorspace conversion

@@ +32,3 @@
+  DITHER_VERTERR,
+  DITHER_HALFTONE
+} GstColorSpaceDitherMethod;

Namespace pollution. GST_COLOR_SPACE_DITHER_METHOD_NONE, etc

@@ +62,3 @@
+  void (*convert)      (GstColorSpaceConvert *convert, GstVideoFrame *dest,
const GstVideoFrame *src);
+  void (*matrix)       (GstColorSpaceConvert *convert, gpointer pixels);
+  void (*dither16)     (GstColorSpaceConvert *convert, guint16 * pixels, int
j);

No padding and not sure if we want all these fields public, or even any of
them. Probably not and it should just go to the .c file

::: gst-libs/gst/video/gstcms.h
@@ +70,3 @@
+void gst_cms_color_transfer_function_unapply (GstCMSColor * dest,
+    GstCMSColor * src);
+void gst_cms_color_gamut_clamp (GstCMSColor * dest, GstCMSColor * src);

Should this be public API at all? Or just internally used by the colorspace
convert functions? Maybe don't install the header until someone actually needs
this :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.