[Bug 731349] New: GstQueueArray doesn't expand when initial size is 1
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jun 6 16:50:19 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=731349
GStreamer | gstreamer (core) | unspecified
Summary: GstQueueArray doesn't expand when initial size is 1
Classification: Platform
Product: GStreamer
Version: unspecified
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gstreamer (core)
AssignedTo: gstreamer-bugs at lists.freedesktop.org
ReportedBy: evan at coeus-group.com
QAContact: gstreamer-bugs at lists.freedesktop.org
GNOME version: ---
Created an attachment (id=278064)
View: https://bugzilla.gnome.org/attachment.cgi?id=278064
Review: https://bugzilla.gnome.org/review?bug=731349&attachment=278064
queuearray: add gst_queue_array_new_with_free_func
If you create a GstQueueArray with a size of 1, then call push_tail when there
is already one value in the array then gstreamer will not correctly expand the
array. The problem is here:
guint newsize = (3 * array->size) / 2;
(3 * 1) / 2 == 1, which is the same size as the existing array.
Attached patch just does this instead:
guint newsize = MAX ((3 * array->size) / 2, array->size + 1);
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list