[Bug 731351] New: x264enc: Shift PTS and DTS with bframes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731351
  GStreamer | gst-plugins-ugly | git

           Summary: x264enc: Shift PTS and DTS with bframes
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: nicolas.dufresne at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In presence of b-frames, x264 will produce negative DTS, which isn't supported
by GStreamer. In order to work-around this, we shift the DTS forward to make it
non-zero. This has the impact that we don't respect that rule where PTS >= DTS.
While most element only uses that for ordering, it's not to much of an issue.

The problem though is present in FLV format. The container stores the DTS and a
positive delta (PTS - DST). As PTS >= DTS is not respected, we are unable to
correctly calculate the required delta.

The solution I propose is to shift both DTS and PTS accordingly. This way they
stay aligned to their original. This expose another bug in the encoder, which
says that on keyframe PTS == DTS, this is not true for H264, but I that being a
just a warning, I would not mind too much right now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.