[Bug 659573] multipartdemux: segfault

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=659573
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197244|none                        |reviewed
             status|                            |

--- Comment #15 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-06-10 21:18:31 UTC ---
Review of attachment 197244:
 --> (https://bugzilla.gnome.org/review?bug=659573&attachment=197244)

I'm not big fan of that approach, and can't find anything in the spec to
justify. I think the input is invalid, we should not crash of course.

::: gst/multipart/multipartdemux.c
@@ +202,3 @@
+          DEFAULT_MIME_IF_NULL,
+          G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS));
+

I don't like these property names. Shorter names would do just fine. Also,
rules is 80 char/lines.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.