[Bug 659573] multipartdemux: segfault

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=659573
  GStreamer | gst-plugins-good | git

--- Comment #20 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2014-06-11 16:50:35 UTC ---
(In reply to comment #18)
> > Yes, 7d78a68c introduced unconditional use of the pad after call of this
> > function.
> 
> It did? As far as I can tell it adds some code that uses srcpad->foo before the
> already-existing gst_pad_push(srcpad->pad) call. I don't think this counts as
> 'introduced unconditional use'?

Maybe there already was such use then ? I did not checkout that rev to look
further in time. In any case, as Nicolas pointed out, that branch was not taken
when there was no MIME type, so that explains why it would not have crashed
with any previous dereference, so all is good (and I removed that part of my
patch, since it's pointless anyway).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.