[Bug 731400] pnmdec: PNMDecoder gives sticky event warning

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731400
  GStreamer | gst-plugins-bad | unspecified

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278327|none                        |reviewed
             status|                            |

--- Comment #9 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-06-12 13:53:46 UTC ---
Review of attachment 278327:
 --> (https://bugzilla.gnome.org/review?bug=731400&attachment=278327)

Great, it is working and the patch looks good. Just some minor tweaks/cleanup
below and I'll merge it.

Please submit the new patch with the documentation fixes.

::: gst/pnm/gstpnmdec.c
@@ +296,3 @@
+            gst_video_decoder_set_output_state (GST_VIDEO_DECODER (s), format,
+            s->mngr.info.width, s->mngr.info.height, s->input_state);
+        gst_video_decoder_negotiate (GST_VIDEO_DECODER (s));

Remember to check the result of this. If it fails, return NOT_NEGOTIATED for
upstream.

@@ +304,3 @@
+        offset = s->mngr.data_offset;
+        data = gst_adapter_take_buffer (adapter, offset);
+        gst_buffer_unref (data);

You can use gst_adapter_flush to remove the first bytes of an adapter.

::: gst/pnm/gstpnmdec.h
@@ +42,3 @@
+  GstVideoDecoder decoder;
+  GstVideoCodecState *input_state;
+  GstVideoCodecState *output_state;

You're not really using input_state or output_state, better to remove those
attributes.

Make sure to unref the output_state you get from the set_output_state call.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.