[Bug 725248] videobox fails to negotiate in an environment with possible RGB input.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725248
  GStreamer | gst-plugins-good | git

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278262|none                        |needs-work
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-06-12 14:29:49 UTC ---
Review of attachment 278262:
 --> (https://bugzilla.gnome.org/review?bug=725248&attachment=278262)

Thanks for spotting the issue, it is indeed related to the AYUV format as
videobox can convert from both AYUV to other YUV and also to RGB formats.

Unfortunately your patch introduces a regression, the pipeline: "gst-launch-1.0
videotestsrc  ! "video/x-raw,format={AYUV}" ! videoconvert ! videobox !
"video/x- raw,format={RGBA}" ! videoconvert ! xvimagesink" won't work anymore
as videobox now claims it can't convert AYUV -> RGBA while it can (and could
before your patch).

I guess we need to handle AYUV differently as it means that videobox can
produce both RGB and YUV formats. We need to handle AYUV separately on that if
to set both seen_rgb and seen_yuv to true. (In the loop case you can even break
the loop after this case as both seen_yuv/rgb are set anyway)

::: gst/videobox/gstvideobox.c
@@ -2877,1 @@
           seen_rgb = TRUE;

This same issue appears another time when iterating the list just above this
occurence

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.