[Bug 730960] tsdemux: allow changing program in playing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jun 12 09:53:25 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=730960
  GStreamer | gst-plugins-bad | unspecified

--- Comment #7 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-06-12 16:53:20 UTC ---
(In reply to comment #6)
> Review of attachment 277487 [details]:
> 
> While it looks correct, I'm a bit worried about having the program shared
> accross so many structures. Wondering if a trivial refcounting system for
> programs wouldn't be needed, to ensure we only free it once nobody (whether
> element or pads) need it anymore

It is harmless to add that, but the programs are only freed after a call do
'deactivate_program'. but you made me realize another issue:

what would happen if we are doing a program switch and the current program
(still not fully switched) gets deactivated? If no pads have been added yet it
will EOS prematurely. If we prevent pads from being removed from a switching
program until the new program is ready (no-more-pads) we can also hang if the
user selects a program that isn't available. But in this later case it would be
the user's fault.

What do you think?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list